You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/27 21:33:24 UTC
svn commit: r1776198 - in
/jmeter/trunk/src/components/org/apache/jmeter/config: CSVDataSet.java
CSVDataSetBeanInfo.java
Author: pmouawad
Date: Tue Dec 27 21:33:24 2016
New Revision: 1776198
URL: http://svn.apache.org/viewvc?rev=1776198&view=rev
Log:
Sonar : Make SHARE_TAGS private
Modified:
jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java
jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java?rev=1776198&r1=1776197&r2=1776198&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java Tue Dec 27 21:33:24 2016
@@ -123,7 +123,7 @@ public class CSVDataSet extends ConfigTe
try {
final BeanInfo beanInfo = Introspector.getBeanInfo(this.getClass());
final ResourceBundle rb = (ResourceBundle) beanInfo.getBeanDescriptor().getValue(GenericTestBeanCustomizer.RESOURCE_BUNDLE);
- for(String resKey : CSVDataSetBeanInfo.SHARE_TAGS) {
+ for(String resKey : CSVDataSetBeanInfo.getShareTags()) {
if (propValue.equals(rb.getString(resKey))) {
if (log.isDebugEnabled()) {
log.debug("Converted " + propName + "=" + propValue + " to " + resKey + " using Locale: " + rb.getLocale());
Modified: jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java?rev=1776198&r1=1776197&r2=1776198&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java Tue Dec 27 21:33:24 2016
@@ -36,7 +36,7 @@ public class CSVDataSetBeanInfo extends
private static final String SHAREMODE = "shareMode"; //$NON-NLS-1$
// Access needed from CSVDataSet
- static final String[] SHARE_TAGS = new String[3];
+ private static final String[] SHARE_TAGS = new String[3];
static final int SHARE_ALL = 0;
static final int SHARE_GROUP = 1;
static final int SHARE_THREAD = 2;
@@ -106,4 +106,13 @@ public class CSVDataSetBeanInfo extends
}
return -1;
}
+
+ /**
+ * @return array of String for possible sharing modes
+ */
+ public static String[] getShareTags() {
+ String[] copy = new String[SHARE_TAGS.length];
+ System.arraycopy(SHARE_TAGS, 0, copy, 0, SHARE_TAGS.length);
+ return copy;
+ }
}