[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3809: Consolidate expression manipulation functions into optimizer

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3809:
URL: https://github.com/apache/arrow-datafusion/pull/3809#discussion_r993476632


##########
datafusion/core/src/logical_plan/mod.rs:
##########
@@ -53,6 +53,5 @@ pub use datafusion_expr::{
     reverse, right, round, rpad, rtrim, scalar_subquery, sha224, sha256, sha384, sha512,
     signum, sin, split_part, sqrt, starts_with, strpos, substr, sum, tan, to_hex,
     to_timestamp_micros, to_timestamp_millis, to_timestamp_seconds, translate, trim,
-    trunc, unalias, upper, when, Expr, ExprSchemable, Literal, Operator,
+    trunc, upper, when, Expr, ExprSchemable, Literal, Operator,
 };
-pub use datafusion_optimizer::expr_simplifier::SimplifyInfo;

Review Comment:
   as the datafusion_optimizer is publically exported there is no reason to also re-export it here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org