You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/08 08:54:25 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #10255: feat(chart-data-api): make pivoted columns flattenable
villebro opened a new pull request #10255:
URL: https://github.com/apache/incubator-superset/pull/10255
### SUMMARY
Currently the pivot operation doesn't work properly on the chart data endpoint due to column names being `Tuple[str, ...]`, causing `json.dumps` to fail. This adds the option to flatten the column names in a similar manner to how `viz.py` does it (drop metric name if only single metric present, join column names with comma etc). In addition, the index is returned to the DataFrame as a regular column to keep the pivot output uniform with other post processing operations. The `columns` argument is also made optional to avoid having to do an additional ternary in `buildQuery` when building time series viz plugins.
### TEST PLAN
CI + new tests
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10255: feat(chart-data-api): make pivoted columns flattenable
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10255:
URL: https://github.com/apache/incubator-superset/pull/10255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org