[GitHub] [brooklyn-server] algairim commented on a change in pull request #1187: Added support for tagged bundles

[GitBox <gi...@apache.org>]

algairim commented on a change in pull request #1187:
URL: https://github.com/apache/brooklyn-server/pull/1187#discussion_r650041444



##########
File path: core/src/main/java/org/apache/brooklyn/core/typereg/BrooklynBomYamlCatalogBundleResolver.java
##########
@@ -115,10 +115,16 @@ protected double scoreForNullFormat(Supplier<InputStream> f) {
 
         OsgiBundleInstallationResult result;
         try {
+
+            BasicManagedBundle basicManagedBundle = new BasicManagedBundle(vn.getSymbolicName(), vn.getVersionString(),
+                    null, BrooklynBomBundleCatalogBundleResolver.FORMAT,
+                    null, null);
+            // if the submitted blueprint contains tags, we set them on the bundle, so they can be picked up and used to tag the plan.
+            if( cm.containsKey("tags")) {
+                basicManagedBundle.tags().addTags((Iterable<?>)cm.get("tags"));

Review comment:
       Can `tags` value be a non-Iterable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org