You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "litiliu (via GitHub)" <gi...@apache.org> on 2026/08/27 08:43:15 UTC

[PR] [client] Retry stale out-of-order responses without resetting writer [fluss]

litiliu opened a new pull request, #4125:
URL: https://github.com/apache/fluss/pull/4125

   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink], [rust], [python], [c++], [elixir]). Skip *[component]* if you are unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
     - **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
       - [ ] No generative AI tools used
       - [x] Yes (OpenAI Codex, reviewed by the human contributor)
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   <!--
   Generated-by: OpenAI Codex following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #4121
   
   <!-- What is the purpose of the change -->
   Prevent an idempotent writer from being reset when an out-of-order response reflects an older server state and the acknowledged sequence has advanced while the batch was in flight.
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how they address the issue -->
   - Snapshot each idempotent batch's last acknowledged sequence on every send attempt.
   - Retry an out-of-order response when the acknowledged sequence has advanced since that attempt was sent.
   - Preserve the existing writer reset behavior when no sequence progress has occurred.
   - Cover stale, genuine, and repeated out-of-order response paths in `SenderTest`.
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   - `./mvnw -pl fluss-client -DskipITs -Dtest=SenderTest test`
     - 26 tests passed.
     - Checkstyle and Spotless passed.
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   No public API or storage format changes.
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   No user-facing documentation changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [client] Retry stale out-of-order responses without resetting writer [fluss]

Posted by "leekeiabstraction (via GitHub)" <gi...@apache.org>.
leekeiabstraction merged PR #4125:
URL: https://github.com/apache/fluss/pull/4125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org