[GitHub] brodybits commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion
URL: https://github.com/apache/cordova-android/pull/551#discussion_r233381601
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -117,7 +117,7 @@ if (ext.cdvReleaseSigningPropertiesFile == null && file('../release-signing.prop
 // Cast to appropriate types.
 ext.cdvBuildMultipleApks = cdvBuildMultipleApks == null ? false : cdvBuildMultipleApks.toBoolean();
 ext.cdvVersionCodeForceAbiDigit = cdvVersionCodeForceAbiDigit == null ? false : cdvVersionCodeForceAbiDigit.toBoolean();
-ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : cdvMinSdkVersion
+ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : Integer.parseInt('' + cdvMinSdkVersion)
 
 Review comment:
   Some kind of recasting. This is code that was done in bf327f391614894f84448b84bcaede613ef0d5c7 but got lost somehow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org