[GitHub] tomcat pull request #84: Add tomcat in the cloud abstract implementation

[maxime-beck <gi...@git.apache.org>]

GitHub user maxime-beck opened a pull request:

    https://github.com/apache/tomcat/pull/84

    Add tomcat in the cloud abstract implementation

    ## Tomcat in the Cloud
    _Tomcat in the Cloud_ is a project that seeks to add support for clustering into a cloud environment for a variety of cloud service providers such as OpenShift, Kubernetes, Azure and more.
    
    This commit is the first of many related to this project. It adds the abstract implementation of both **_MemberProvider_** and **_StreamProvider_**.
    
    ### MemberProvider
    Discovers all running instances of Tomcat in the cloud environment.
    
    ### StreamProvider
    Establish connection throughout the cloud network to provide multi-casting in the cloud environment.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maxime-beck/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit fca17b17e947f0546853a06fe2ded5e0af311fbf
Author: Maxime Beck <ma...@redhat.com>
Date:   2017-10-24T15:02:28Z

    Add tomcat in the cloud abstract implementation

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation

[rmaucher <gi...@git.apache.org>]

Github user rmaucher commented on the issue:

    https://github.com/apache/tomcat/pull/84
  
    Abstraction is ok, more importantly limiting the number of impls will make it much much easier to maintain.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat pull request #84: Add tomcat in the cloud abstract implementation

[maxime-beck <gi...@git.apache.org>]

Github user maxime-beck closed the pull request at:

    https://github.com/apache/tomcat/pull/84


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation

[markt-asf <gi...@git.apache.org>]

Github user markt-asf commented on the issue:

    https://github.com/apache/tomcat/pull/84
  
    This needs a wider discussion on the dev list first.
    
    However I do have some initial high level comments:
    - The choice of package is unexpected
    - Headers need to be standard ASF headers
    - Author details need to be removed
    - At least one file appears to have been written by someone other than the person submitting the pull request. That is a huge red flag as it is not clear that the person submitted the pull request has the necessary rights to do so.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation

[jfclere <gi...@git.apache.org>]

Github user jfclere commented on the issue:

    https://github.com/apache/tomcat/pull/84
  
    See also in https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/stream/StreamProvider.java it seems we are reusing their internal interface, what doesn't look quite good, AKA it looks like an implementation detail of the Kubernetes logic.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation

[maxime-beck <gi...@git.apache.org>]

Github user maxime-beck commented on the issue:

    https://github.com/apache/tomcat/pull/84
  
    Apparently Microsoft recently came up with a new container management service **[1]** based on Kubernetes for Azure. This means that all container management providers that we're aiming to support now potentially work with Kubernetes. It makes us rethink our data model and especially our necessity for abstraction.
    
    Because this now needs a higher level of investigation and analysis, I'll close this pull request for now.
    ___
    **[1]** https://azure.microsoft.com/en-us/blog/introducing-azure-container-service-aks-managed-kubernetes-and-azure-container-registry-geo-replication/


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org