[GH] (pekko-http/max-connection-age-followup): Workflow run "Scalafmt" is working again!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Scalafmt" on pekko-http.git/max-connection-age-followup has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
13494db810f02dfc1407f8c231c45bc70560adbe / PJ Fanning <pj...@users.noreply.github.com>
Follow-up to max-connection-age review: document and test infinite grace with a later terminate

Motivation:
Review of #1316 noted that reference.conf only documents one direction of
the interaction between max-connection-age and a server binding termination,
that the combination of max-connection-age-grace = infinite with a later
terminate was not tested, and that some new tests had tight timing margins.

Modification:
- reference.conf: state that a later terminate with an earlier deadline
  shortens a drain started by the age, also with an infinite grace period,
  mirroring http2.md.
- Http2ServerSpec: add a test for max-connection-age-grace = infinite
  followed by terminate(10.millis).
- Http2ServerSpec: widen timing margins (age 1s vs expectNoBytes(700ms),
  terminate(2s) vs expectNoBytes(700ms)).

Result:
The documented and tested behaviour covers both directions, and the timing
sensitive tests have more headroom on loaded CI machines.

Tests:
- sbt "http2-tests/testOnly ...Http2ServerSpec -- -z max-connection-age": 7 tests pass
- scalafmt on the changed spec

References:
Refs #1316

Report URL: https://github.com/apache/pekko-http/actions/runs/36989780175

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org