You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/09/29 15:21:50 UTC
[Impala-ASF-CR] Add vim-specific files to .gitignore
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4562
Change subject: Add vim-specific files to .gitignore
......................................................................
Add vim-specific files to .gitignore
Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
---
M .gitignore
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/4562/1
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4562
to look at the new patch set (#2).
Change subject: Add vim-specific files to .gitignore
......................................................................
Add vim-specific files to .gitignore
Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
---
M .gitignore
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/4562/2
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Add vim-specific files to .gitignore
......................................................................
Add vim-specific files to .gitignore
Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Reviewed-on: http://gerrit.cloudera.org:8080/4562
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M .gitignore
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4562/1/.gitignore
File .gitignore:
Line 1: *~
> Can you move this into the vim section?
I think this is emacs. Should I make an own section for it to encourage emacs users to add their ignores, too?
Line 3: .*.swp
> Can you move this into the vim section?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Seems reasonable.
http://gerrit.cloudera.org:8080/#/c/4562/1/.gitignore
File .gitignore:
Line 1: *~
Can you move this into the vim section?
Line 3: .*.swp
Can you move this into the vim section?
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 1:
I have these files in all my working copies, now I'm curious how others think about adding them to .gitignore.
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add vim-specific files to .gitignore
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add vim-specific files to .gitignore
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4562/1/.gitignore
File .gitignore:
Line 1: *~
> I think this is emacs. Should I make an own section for it to encourage ema
Let's not worry about it then - I know very little about emacs
--
To view, visit http://gerrit.cloudera.org:8080/4562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes