You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/05/02 21:24:40 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1571: Fix NSOne DNS Provider

Kami commented on a change in pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571#discussion_r624757549



##########
File path: libcloud/dns/drivers/nsone.py
##########
@@ -206,7 +206,7 @@ def delete_record(self, record):
 
         return response.status == httplib.OK
 
-    def create_record(self, name, zone, type, data, extra=None):
+    def create_record(self, name, zone, type_, data, extra=None):

Review comment:
       ``type`` argument is part of the standard API (aka is the same for all the provider drivers) so we should use it here as well.
   
   I know it's not ideal since it clashes with a built-int value, but not much we can do at this point (besides changing the standard API + updating all the drivers in the future).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org