You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/23 03:09:16 UTC

[GitHub] sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table
URL: https://github.com/apache/flink/pull/7155#issuecomment-441148157
 
 
   @XuQianJin-Stars Thanks for the PR!
   
   The changes looks good to me. Here hope you can do one more check by test `timestampadd(MINUTE, 1, time '20:20:20')`, I think the process logic of `SqlTimeTypeInfo.TIME, TimeIntervalTypeInfo.INTERVAL_MILLIS` may have the same issue.
   
   Thanks,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services