[jira] [Commented] (THRIFT-3457) thrift client codegen fails due to problematic names

["Fabrice Trillaud (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299783#comment-15299783 ] 

Fabrice Trillaud commented on THRIFT-3457:
------------------------------------------

There's a similar problem I think if a method parameter is called "client", at least in generated Java code, since the generator creates a "methodeName_call" method with a "client" parameter, resulting in a duplicate parameter name.

> thrift client codegen fails due to problematic names
> ----------------------------------------------------
>
>                 Key: THRIFT-3457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3457
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Compiler
>            Reporter: Tolstokulakov Nikolay
>
> thrift/source/thrift/codegen/client.d-mixin-86(272,19): Error: function expected before (), not skip of type int
> This happens if I have parameter with name 'skip' in my interface:
>  enum methodMeta = [
>     TMethodMeta(`getBrands`, 
>       [TParamMeta(`limit`, 1), TParamMeta(`skip`, 2)]
>     ), ....
> As workaround  I rename parameter, but compiler error is not very clear in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)