[GitHub] [fineract] adamsaghy commented on a diff in pull request #2614: FINERACT-1706: Charge back Loan Transaction

[GitBox <gi...@apache.org>]

adamsaghy commented on code in PR #2614:
URL: https://github.com/apache/fineract/pull/2614#discussion_r980265987


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java:
##########
@@ -126,6 +126,11 @@ private LoanStatus getNextState(LoanEvent loanEvent, Loan loan) {
                     newState = overpaidTransition();
                 }
             break;
+            case LOAN_CHARGEBACK:
+                if (anyOfAllowedWhenComingFrom(from, LoanStatus.CLOSED_OBLIGATIONS_MET, LoanStatus.ACTIVE)) {
+                    newState = activeTransition();

Review Comment:
   This one is not complete:
   
   If it was ACTIVE
   -  it remains active,
   if it was CLOSED_OBLIGATIONS_MET 
   - it goes to OVERPAID
   if it was OVERPAID (missing from the list)
   - it remains OVERPAID
   
   (i double check the last option)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org