You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dutyu (via GitHub)" <gi...@apache.org> on 2023/12/19 02:46:12 UTC
[PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
dutyu opened a new pull request, #28608:
URL: https://github.com/apache/doris/pull/28608
## Proposed changes
No need to get tablet stat if backend is not alive, because we deploy compute nodes on a yarn cluster, there are always some compute nodes which are not alive, so we will always meet lots of error logs like following:
```java
2023-12-18 15:19:44,344 WARN (ForkJoinPool-2-worker-42|83907) [TabletStatMgr.lambda$null$0():71] task exec error. backend[218820]
org.apache.thrift.transport.TTransportException: java.net.ConnectException: Connection refused (Connection refused)
at org.apache.thrift.transport.TSocket.open(TSocket.java:255) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.doris.common.GenericPool$ThriftClientFactory.create(GenericPool.java:143) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.common.GenericPool$ThriftClientFactory.create(GenericPool.java:126) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.commons.pool2.BaseKeyedPooledObjectFactory.makeObject(BaseKeyedPooledObjectFactory.java:62) ~[commons-pool2-2.2.jar:2.2]
at org.apache.commons.pool2.impl.GenericKeyedObjectPool.create(GenericKeyedObjectPool.java:1012) ~[commons-pool2-2.2.jar:2.2]
at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:356) ~[commons-pool2-2.2.jar:2.2]
at org.apache.commons.pool2.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:277) ~[commons-pool2-2.2.jar:2.2]
at org.apache.doris.common.GenericPool.borrowObject(GenericPool.java:95) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.catalog.TabletStatMgr.lambda$null$0(TabletStatMgr.java:64) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:1.8.0_301]
at com.google.common.collect.CollectSpliterators$1WithCharacteristics.lambda$forEachRemaining$1(CollectSpliterators.java:72) ~[guava-32.1.2-jre.jar:?]
at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110) ~[?:1.8.0_301]
at com.google.common.collect.CollectSpliterators$1WithCharacteristics.forEachRemaining(CollectSpliterators.java:72) ~[guava-32.1.2-jre.jar:?]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_301]
at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291) ~[?:1.8.0_301]
at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731) ~[?:1.8.0_301]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_301]
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1067) ~[?:1.8.0_301]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1703) ~[?:1.8.0_301]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:172) ~[?:1.8.0_301]
Caused by: java.net.ConnectException: Connection refused (Connection refused)
at java.net.PlainSocketImpl.socketConnect(Native Method) ~[?:1.8.0_301]
at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:476) ~[?:1.8.0_301]
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:218) ~[?:1.8.0_301]
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:200) ~[?:1.8.0_301]
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:394) ~[?:1.8.0_301]
at java.net.Socket.connect(Socket.java:606) ~[?:1.8.0_301]
at org.apache.thrift.transport.TSocket.open(TSocket.java:250) ~[libthrift-0.16.0.jar:0.16.0]
... 19 more
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862632564
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.97 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17184151779 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862882069
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862072182
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.36 seconds
stream load tsv: 590 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17217997672 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862068088
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 355120d228d66a57984ea23cf988677920b6d50f, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4707 4425 4430 4425
q2 356 157 167 157
q3 1470 1264 1238 1238
q4 1122 907 892 892
q5 3171 3172 3179 3172
q6 248 126 123 123
q7 999 484 478 478
q8 2215 2257 2246 2246
q9 6690 6729 6706 6706
q10 3218 3297 3275 3275
q11 314 181 185 181
q12 349 211 205 205
q13 4564 3822 3801 3801
q14 241 214 217 214
q15 574 529 524 524
q16 439 384 385 384
q17 1023 583 565 565
q18 7198 6821 7038 6821
q19 1569 1483 1425 1425
q20 557 319 308 308
q21 3099 2650 2682 2650
q22 345 275 284 275
Total cold run time: 44468 ms
Total hot run time: 40065 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4358 4327 4350 4327
q2 270 165 171 165
q3 3534 3531 3521 3521
q4 2381 2378 2369 2369
q5 5746 5728 5744 5728
q6 242 122 118 118
q7 2399 1874 1870 1870
q8 3547 3546 3541 3541
q9 9004 8995 8986 8986
q10 3911 3978 4030 3978
q11 506 376 370 370
q12 762 609 598 598
q13 4311 3557 3529 3529
q14 287 265 252 252
q15 574 517 522 517
q16 515 462 466 462
q17 1887 1866 1844 1844
q18 8616 8313 8189 8189
q19 1747 1743 1771 1743
q20 2249 1961 1934 1934
q21 6501 6175 6160 6160
q22 506 450 433 433
Total cold run time: 63853 ms
Total hot run time: 60634 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862024654
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862882156
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu closed pull request #28608: [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive.
URL: https://github.com/apache/doris/pull/28608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862567614
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #28608:
URL: https://github.com/apache/doris/pull/28608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862742662
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](job) No need to query some backends which are not alive. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862797138
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit f074988795322403210c8f89796bc2ad3993b247, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4710 4421 4389 4389
q2 371 143 158 143
q3 1464 1269 1278 1269
q4 1110 914 917 914
q5 3160 3149 3150 3149
q6 251 129 127 127
q7 989 492 482 482
q8 2197 2205 2188 2188
q9 6713 6627 6661 6627
q10 3221 3262 3264 3262
q11 312 184 194 184
q12 356 203 208 203
q13 4558 3799 3810 3799
q14 243 210 208 208
q15 578 521 518 518
q16 443 380 384 380
q17 1001 598 548 548
q18 7146 6901 6963 6901
q19 1512 1378 1395 1378
q20 538 295 310 295
q21 3059 2670 2679 2670
q22 344 278 281 278
Total cold run time: 44276 ms
Total hot run time: 39912 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4350 4364 4365 4364
q2 266 165 170 165
q3 3522 3521 3516 3516
q4 2392 2360 2366 2360
q5 5731 5763 5771 5763
q6 243 124 123 123
q7 2384 1893 1888 1888
q8 3528 3520 3522 3520
q9 9050 9026 8971 8971
q10 3955 4000 3996 3996
q11 493 376 372 372
q12 764 603 601 601
q13 4293 3543 3569 3543
q14 290 256 250 250
q15 577 518 522 518
q16 501 460 449 449
q17 1887 1864 1865 1864
q18 8704 8293 8294 8293
q19 1752 1734 1752 1734
q20 2255 1946 1926 1926
q21 6535 6193 6150 6150
q22 523 405 422 405
Total cold run time: 63995 ms
Total hot run time: 60771 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](tablet-stat) No need to get tablet stat if backend is not alive. [doris]
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #28608:
URL: https://github.com/apache/doris/pull/28608#issuecomment-1862020335
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org