[jira] [Commented] (FLINK-16160) Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path

["Jark Wu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073643#comment-17073643 ] 

Jark Wu commented on FLINK-16160:
---------------------------------

Hi [~docete], I think this PR mixes the bug fix and new feature. Could you separate them into two issues? 
The first issue is just fix proctime() doesn't work for {{createTemporaryTable}}, and I think the root cause is [this line|https://github.com/apache/flink/blob/release-1.10/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/ConnectTableDescriptor.java#L143].  We should fix this for 1.10 too. 
The other issue is introduce a new API to define rowtime and proctime. 

> Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-16160
>                 URL: https://issues.apache.org/jira/browse/FLINK-16160
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / API
>            Reporter: Zhenghua Gao
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In ConnectTableDescriptor#createTemporaryTable, the proctime/rowtime properties are ignored so the generated catalog table is not correct. We should fix this to let TableEnvironment#connect() support watermark.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)