You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liu-zhaokun <gi...@git.apache.org> on 2017/08/04 06:14:34 UTC
[GitHub] spark pull request #18842: [SPARK-21636] Several configurations which only a...
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/spark/pull/18842
[SPARK-21636] Several configurations which only are used in unit tests should be removed
[https://issues.apache.org/jira/browse/SPARK-21636](https://issues.apache.org/jira/browse/SPARK-21636)
spark.core.connection.ack.wait.timeout and spark.shuffle.io.connectionTimeout only are used in unit tests.So I think they should be removed and we can replace them with spark.network.timeout
in those unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/spark master08041057
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18842
----
commit 3598a03bd0d4ab15d5949371480c3ac71c0eefd0
Author: liuzhaokun <li...@zte.com.cn>
Date: 2017-08-04T06:12:34Z
[SPARK-21636] Several configurations which only are used in unit tests should be removed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18842
I would suggest not to remove such configurations even if it is only used in UT, in case some users depend on them explicitly, abruptly removing them will break the compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18842: [SPARK-21636] Several configurations which only a...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/spark/pull/18842
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/18842
@jerryshao
OK.Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18842
No, these may be set by callers. It's not clear it's not on purpose. I would close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18842: [SPARK-21636] Several configurations which only are used...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18842
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org