[GitHub] [incubator-daffodil] tuxji commented on a change in pull request #416: Throw SDE in the case of a choice with no branches

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #416:
URL: https://github.com/apache/incubator-daffodil/pull/416#discussion_r487180702



##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section15/choice_groups/TestChoice.scala
##########
@@ -38,6 +38,9 @@ class TestChoice {
 
   import TestChoice._
 
+  @Test def test_choice_noBranch (): Unit = { runnerCH.runOneTest("choice_noBranch") }
+
+  @Test def test_optionalChoice00(): Unit = { runnerCH.runOneTest("optionalChoice00") }

Review comment:
       Rick, you need to delete test_optionalChoice00 since the "optionalChoice00" test doesn't exist.  This is the reason why the PR checks are failing with the message
   
   ```
   [error] Test org.apache.daffodil.section15.choice_groups.TestChoice.test_optionalChoice00 failed: org.apache.daffodil.tdml.TDMLExceptionImpl: test optionalChoice00 was not found., took 0.001 sec
   [error]     at org.apache.daffodil.tdml.TDMLException$.apply(TDMLException.scala:31)
   [error]     at org.apache.daffodil.tdml.DFDLTestSuite.runOneTest(TDMLRunner.scala:388)
   [error]     at org.apache.daffodil.tdml.Runner.runOneTest(RunnerFactory.scala:144)
   [error]     at org.apache.daffodil.tdml.Runner.runOneTest(RunnerFactory.scala:150)
   [error]     at org.apache.daffodil.section15.choice_groups.TestChoice.test_optionalChoice00(TestChoice.scala:43)
   [error]     ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org