You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Xpray <gi...@git.apache.org> on 2017/10/16 08:27:08 UTC
[GitHub] flink pull request #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldNam...
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4829
[FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with Boolean pref…
Fix Bug that fieldName with Boolean prefix can't be parsed by ExpressionParser
## What is the purpose of the change
Fix bug that field names with boolean prefix like "truex" or "FALSE_TARGET" can't be parsed by {{ExpressionParser}}
## Brief change log
use `||| ` instead of ` | ` in `atom` parser, try to match as long as possible, and exchanging of positions of `fieldReference` parser and ` literalExpr ` parser is necessary, because `boolean` can be matched by both parsers, then it's captured by the latter one ` literalExpr ` .
## Verifying this change
This change added tests and can be verified as follows:
StringExpressionTest.testFieldWithBooleanPrefix
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive):no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not documented
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xpray/flink FLINK-7759
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4829.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4829
----
commit 4cdfd18148a1a4e97e078bee6ccf4ba8c20c8034
Author: Xpray <le...@gmail.com>
Date: 2017-10-16T08:13:26Z
[FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with Boolean prefix can't be parsed by ExpressionParser.
----
---
[GitHub] flink pull request #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldNam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4829
---
[GitHub] flink pull request #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldNam...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4829#discussion_r145653182
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/StringExpressionTest.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.batch.table.stringexpr
+
+import org.apache.flink.table.expressions.{ExpressionParser, Literal, UnresolvedFieldReference}
+import org.junit.{Assert, Test}
+
+class StringExpressionTest {
--- End diff --
I've converted the test into an expression test (extending `ExpressionTestBase`) and moved it to `org.apache.flink.table.expressions`.
---
[GitHub] flink issue #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4829
Thanks for the PR @Xpray.
This looks good. Will merge it.
---
[GitHub] flink pull request #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldNam...
Posted by Xpray <gi...@git.apache.org>.
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4829#discussion_r145659580
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/StringExpressionTest.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.batch.table.stringexpr
+
+import org.apache.flink.table.expressions.{ExpressionParser, Literal, UnresolvedFieldReference}
+import org.junit.{Assert, Test}
+
+class StringExpressionTest {
--- End diff --
That's great, I should have done this.
---