[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6917: Improvements and cleanup on the javadocs of qeumu img

[GitBox <gi...@apache.org>]

stephankruggg commented on code in PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#discussion_r1030680395


##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java:
##########
@@ -140,43 +140,50 @@ public QemuImg(final int timeout, final boolean skipZeroIfSupported, final boole
         this.version = LibvirtConnection.getConnection().getVersion();
     }
 
+    /**
+     * Creates a QemuImg object.
+     *
+     * @param timeout
+     *            The timeout of scripts executed by this QemuImg object.
+     */
     public QemuImg(final int timeout) throws LibvirtException, QemuImgException {
         this(timeout, false, false);
     }
 
+    /**
+     * Sets the timeout for the scripts executed by this QemuImg object.

Review Comment:
   ```suggestion
        * Sets the timeout of the scripts executed by this QemuImg object.
   ```



##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java:
##########
@@ -140,43 +140,50 @@ public QemuImg(final int timeout, final boolean skipZeroIfSupported, final boole
         this.version = LibvirtConnection.getConnection().getVersion();
     }
 
+    /**
+     * Creates a QemuImg object.
+     *
+     * @param timeout
+     *            The timeout of scripts executed by this QemuImg object.
+     */
     public QemuImg(final int timeout) throws LibvirtException, QemuImgException {
         this(timeout, false, false);
     }
 
+    /**
+     * Sets the timeout for the scripts executed by this QemuImg object.
+     *
+     * @param timeout
+     *            The timeout for the object.

Review Comment:
   ```suggestion
        *            The timeout of the object.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org