You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sebastien Briquet (JIRA)" <ji...@apache.org> on 2017/08/14 16:04:00 UTC

[jira] [Comment Edited] (WICKET-6448) IndicatingAjaxButton should prevent double submit

    [ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125874#comment-16125874 ] 

Sebastien Briquet edited comment on WICKET-6448 at 8/14/17 4:03 PM:
--------------------------------------------------------------------

I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent).

Moreover, thinking back on the implementation...
I'm figuring out that we need to use both #click and #ajaxStart.

#click for displaying the indicator
#ajaxStart for disabling the button

Otherwise the indicator will be always be shown on every ajax request in the current page...


was (Author: sebfz1):
I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent).

Moreover, thinking back on the implementation...
I'm figuring out that we need to user both #click and #ajaxStart.

#click for displaying the indicator
#ajaxStart for disabling the button

Otherwise the indicator will be always be shown on every ajax request in the current page...

> IndicatingAjaxButton should prevent double submit
> -------------------------------------------------
>
>                 Key: WICKET-6448
>                 URL: https://issues.apache.org/jira/browse/WICKET-6448
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 8.0.0-M6
>            Reporter: Kamil
>         Attachments: showcase-preventClick.zip
>
>
> 1)Run the app
> 2)Click "submit" quickly several times
> 3)Watch the console



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)