You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yongjiaw <gi...@git.apache.org> on 2015/10/30 18:16:46 UTC
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
GitHub user yongjiaw opened a pull request:
https://github.com/apache/spark/pull/9379
[SPARK-11413][BUILD] Bump joda-time version to 2.9 for java 8 and s3
It's a known issue that joda-time before 2.8.1 is incompatible with java 1.8u60 or later, which causes s3 request to fail. This affects Spark when using s3 as data source.
https://github.com/aws/aws-sdk-java/issues/444
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yongjiaw/spark SPARK-11413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9379.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9379
----
commit bfeb6f472294df833a8b4540ceb5cb920fc4d1aa
Author: Yongjia Wang <yo...@gmail.com>
Date: 2015-10-30T16:52:34Z
[SPARK-11413][BUILD] Bump joda-time version to 2.9 for java 8 and s3
It's a known issue that joda-time before 2.8.1 is incompatible with java 1.8u60 or later, which causes s3 request to fail. This affects Spark when using s3 as data source.
https://github.com/aws/aws-sdk-java/issues/444
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152960914
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by yongjiaw <gi...@git.apache.org>.
Github user yongjiaw commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152742188
On my local machine, running ./dev/run-tests also fails but for different tests.
But it should be unrelated to the change, because even I run it with the unmodified master branch, it still fails the network-shuffle test.
This is the last few lines of the console output.
```
[info] Test org.apache.spark.mllib.regression.JavaLassoSuite.runLassoUsingConstructor started
[info] Test org.apache.spark.mllib.regression.JavaLassoSuite.runLassoUsingStaticMethods started
[info] Test run finished: 0 failed, 0 ignored, 2 total, 6.108s
-- org.jblas INFO Deleting /local_disk/git/yongjiaw_spark/target/tmp/jblas3269426321238629267/libjblas.so
-- org.jblas INFO Deleting /local_disk/git/yongjiaw_spark/target/tmp/jblas3269426321238629267/libjblas_arch_flavor.so
-- org.jblas INFO Deleting /local_disk/git/yongjiaw_spark/target/tmp/jblas3269426321238629267
[info] ScalaTest
[info] Run completed in 1 hour, 23 minutes.
[info] Total number of tests run: 709
[info] Suites: completed 141, aborted 0
[info] Tests: succeeded 709, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[info] Passed: Total 818, Failed 0, Errors 0, Passed 818
[error] (network-shuffle/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] (network-common/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] (sql/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 5157 s, completed Oct 31, 2015 2:47:48 PM
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152675215
@yongjiaw do you see this failure locally? Some of these are spurious failures but I can't quite make out if there's a real one here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152773789
**[Test build #1966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1966/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152625237
**[Test build #44689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44689/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:\n * `public abstract class MemoryConsumer `\n * `final class ShuffleExternalSorter extends MemoryConsumer `\n * `public final class BytesToBytesMap extends MemoryConsumer `\n * ` public final class MapIterator implements Iterator<Location> `\n * `public final class UnsafeExternalSorter extends MemoryConsumer `\n * ` class SpillableIterator extends UnsafeSorterIterator `\n * `public final class UnsafeSorterSpillReader extends UnsafeSorterIterator `\n * `public final class UnsafeSorterSpillWriter `\n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152594102
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152651497
**[Test build #1963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1963/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152594060
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152630670
**[Test build #1963 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1963/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152596251
**[Test build #44689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44689/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152592913
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152625292
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152822945
Seems OK to me in that the release notes do not indicate any incompatible changes, and the tests pass, and it fixes some bugs. We don't actually use Joda time in Spark; it appears to be added for Hive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152625295
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44689/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152657479
**[Test build #1964 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1964/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152765204
**[Test build #1966 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1966/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152591648
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11413][BUILD] Bump joda-time version to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9379#issuecomment-152671020
**[Test build #1964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1964/consoleFull)** for PR 9379 at commit [`bfeb6f4`](https://github.com/apache/spark/commit/bfeb6f472294df833a8b4540ceb5cb920fc4d1aa).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org