You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 02:16:42 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new pull request, #1854: Add two `from` methods for `FixedSizeBinaryArray`
HaoYang670 opened a new pull request, #1854:
URL: https://github.com/apache/arrow-rs/pull/1854
Signed-off-by: remzi <13...@gmail.com>
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1852.
# Rationale for this change
Users can easily build `FixedSizeBinaryArray` from vectors.
# What changes are included in this PR?
`From<Vec<Option<&[u8]>>> for FixedSizeBinaryArray`
`From<Vec<&[u8]>> for FixedSizeBinaryArray`
# Are there any user-facing changes?
Yes. new APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1854: Add two `from` methods for `FixedSizeBinaryArray`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1854:
URL: https://github.com/apache/arrow-rs/pull/1854#issuecomment-1153397189
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1854](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f872e3) into [master](https://codecov.io/gh/apache/arrow-rs/commit/c08e5324d11a8a2b9998d0d625876815f4954968?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08e532) will **decrease** coverage by `0.00%`.
> The diff coverage is `36.36%`.
> :exclamation: Current head 2f872e3 differs from pull request most recent head 9731420. Consider uploading reports for the commit 9731420 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 83.49% 83.49% -0.01%
==========================================
Files 201 201
Lines 56903 56906 +3
==========================================
+ Hits 47511 47512 +1
- Misses 9392 9394 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2JpbmFyeS5ycw==) | `92.79% <0.00%> (-0.52%)` | :arrow_down: |
| [parquet/src/arrow/array\_reader/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL2J1aWxkZXIucnM=) | `93.50% <ø> (ø)` | |
| [parquet/src/arrow/array\_reader/byte\_array.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL2J5dGVfYXJyYXkucnM=) | `85.71% <ø> (ø)` | |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `96.87% <ø> (ø)` | |
| [parquet/src/arrow/arrow\_writer/levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyL2xldmVscy5ycw==) | `96.92% <ø> (ø)` | |
| [parquet/src/arrow/arrow\_writer/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyL21vZC5ycw==) | `97.53% <ø> (ø)` | |
| [parquet/src/arrow/buffer/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYnVmZmVyL2JpdF91dGlsLnJz) | `100.00% <ø> (ø)` | |
| [parquet/src/arrow/buffer/converter.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYnVmZmVyL2NvbnZlcnRlci5ycw==) | `83.33% <ø> (ø)` | |
| [parquet/src/arrow/buffer/dictionary\_buffer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYnVmZmVyL2RpY3Rpb25hcnlfYnVmZmVyLnJz) | `94.44% <ø> (ø)` | |
| [parquet/src/arrow/buffer/offset\_buffer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYnVmZmVyL29mZnNldF9idWZmZXIucnM=) | `94.79% <ø> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/arrow-rs/pull/1854/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08e532...9731420](https://codecov.io/gh/apache/arrow-rs/pull/1854?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1854: Add two `from` methods for `FixedSizeBinaryArray`
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1854:
URL: https://github.com/apache/arrow-rs/pull/1854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org