You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2015/11/12 01:17:36 UTC
[GitHub] incubator-apex-core pull request: - APEX-257 #resolve #comment Fix...
GitHub user ilooner opened a pull request:
https://github.com/apache/incubator-apex-core/pull/165
- APEX-257 #resolve #comment Fixed unit test for FastClassIndexReader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/incubator-apex-core APEX-257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 3d98664ee3689e31af7e3c6ee69d2f946b57c13a
Author: Timothy Farkas <ti...@datatorrent.com>
Date: 2015-11-12T00:08:07Z
- APEX-257 #resolve #comment Fixed unit test for FastClassIndexReader
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: - APEX-257 #resolve #comment Fix...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: - APEX-257 #resolve #comment Fix...
Posted by siyuanh <gi...@git.apache.org>.
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/165#discussion_r44621316
--- Diff: engine/src/test/java/com/datatorrent/stram/webapp/asm/FastClassIndexReaderTest.java ---
@@ -91,7 +91,7 @@ public void testPerformance() throws Exception
jar.close();
- jar = new JarFile("/usr/lib/jvm/java-7-oracle/jre/lib/rt.jar");
--- End diff --
My bad, but travis didn't catch that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: - APEX-257 #resolve #comment Fix...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/165#issuecomment-155955021
@siyuanh please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---