You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Nettleton <rn...@hortonworks.com> on 2016/03/03 17:47:16 UTC
Re: Review Request 42499: Exporting Blueprint doesn't have some
configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42499/#review121874
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 19, 2016, 2:33 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42499/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 2:33 p.m.)
>
>
> Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14720
> https://issues.apache.org/jira/browse/AMBARI-14720
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprint doesn't have configs:
> [atlas.cluster.name, hive.exec.post.hooks] in config group hive-site
> [atlas.server.bind.address] in config group application-properties
> [kafka.metrics.reporters] in config group kafka-broker
> [metrics.reporter.register] in config group storm-site
>
> Solved by moving NonTopologyUpdaters out from SingleHostTopologyUpdaters and by adding a updateForBlueprintExport method for NonTopologyUpdater class. When export is done property values in configurations are modified accordingly to the updateForBlueprintExport method.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java dcedd51
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 1afd6a8
>
> Diff: https://reviews.apache.org/r/42499/diff/
>
>
> Testing
> -------
>
> 2 Test cases are added.
>
> Total run:830
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Return code from stack upgrade command, retcode = 0
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:11:36.489s
> [INFO] Finished at: Tue Jan 19 15:10:19 CET 2016
> [INFO] Final Memory: 33M/1132M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Daniel Gergely
>
>