You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/14 06:16:46 UTC

[GitHub] [pulsar] murong00 opened a new pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

murong00 opened a new pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959


   ### Motivation
   
   Fixes #6761
   
   ### Modifications
   
   Correct tokenSecretKey base64 inline description in documents (based master & version 2.5.1) and examples.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-630444274


   @murong00 Can you also fix the documentation of 2.5.1?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-631182546


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-628977140


   @jiazhai What do you mean? This pr has been included fix `data:base64,` in `TokenAuthWithSymmetricKeys.java` which is a base test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-630673058


   > @jiazhai What do you mean? This pr has been included fix `data:base64,` in `TokenAuthWithSymmetricKeys.java` which is a base test.
   
   I found that change. thanks for the work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-628492475


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-631182372


   > @murong00 Can you also fix the documentation of 2.5.1?
   
   Already fixed in this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-628972302


   @murong00 Would you please also fix the "data:base64," in test "TokenAuthWithSymmetricKeys.java"?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 commented on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-631197736


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 removed a comment on pull request #6959: [Issue 6761] Correct tokenSecretKey base64 inline description

Posted by GitBox <gi...@apache.org>.
murong00 removed a comment on pull request #6959:
URL: https://github.com/apache/pulsar/pull/6959#issuecomment-631182546


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org