[GitHub] [druid] liran-funaro commented on a change in pull request #10001: Optimizing incremental-index ingestion using off-heap key/value map (OakMap)

[GitBox <gi...@apache.org>]

liran-funaro commented on a change in pull request #10001:
URL: https://github.com/apache/druid/pull/10001#discussion_r443224110



##########
File path: server/src/main/java/org/apache/druid/segment/realtime/plumber/Sink.java
##########
@@ -365,7 +372,7 @@ private FireHydrant makeNewCurrIndex(long minTimestamp, DataSchema schema)
         .setReportParseExceptions(reportParseExceptions)
         .setMaxRowCount(maxRowsInMemory)
         .setMaxBytesInMemory(maxBytesInMemory)

Review comment:
       Hi @yuanlihan. I added a new commit which resolves this issue.
   Now `maxBytesInMemory` default is set differently when using `oak` or `offheap` index type.
   I also added this to the documentation.
   Thanks again for identifying this issue!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org