You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/01/12 13:39:52 UTC

Review Request 29805: Add "Downgrade" button to Manual Step / Failure box

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29805/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-9087
    https://issues.apache.org/jira/browse/AMBARI-9087


Repository: ambari


Description
-------

For Manual Steps / Failure box, add a "Downgrade" button in red.
So the buttons that appear are:
Failure
[Downgrade] [Ignore and Proceed] [Retry]
Note that "Ignore and Proceed" should appear only when it is not skippable.
Manual Steps
[Downgrade] [Proceed]
Upon clicking [Downgrade], show a confirmation popup:
Downgrade to <Version>
Are you sure you wish to abort the upgrade process and downgrade to <version>?"
[Cancel] [Proceed with Downgrade]


Diffs
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js bbd69fa 
  ambari-web/app/messages.js 1fbaded 
  ambari-web/app/templates/main/admin/stack_and_upgrade.hbs 674a58e 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs bca7dc8 
  ambari-web/app/utils/ajax/ajax.js a7ee18d 
  ambari-web/app/views/main/admin/stack_and_upgrade_view.js 0cb17ea 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js c4fc0ed 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js d4e819c 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 6388692 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js cba70bd 

Diff: https://reviews.apache.org/r/29805/diff/


Testing
-------

5215 tests complete (9 seconds)
  60 tests pending


Thanks,

Andrii Tkach

Re: Review Request 29805: Add "Downgrade" button to Manual Step / Failure box

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29805/#review67643
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Янв. 12, 2015, 12:39 п.п., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29805/
> -----------------------------------------------------------
> 
> (Updated Янв. 12, 2015, 12:39 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-9087
>     https://issues.apache.org/jira/browse/AMBARI-9087
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For Manual Steps / Failure box, add a "Downgrade" button in red.
> So the buttons that appear are:
> Failure
> [Downgrade] [Ignore and Proceed] [Retry]
> Note that "Ignore and Proceed" should appear only when it is not skippable.
> Manual Steps
> [Downgrade] [Proceed]
> Upon clicking [Downgrade], show a confirmation popup:
> Downgrade to <Version>
> Are you sure you wish to abort the upgrade process and downgrade to <version>?"
> [Cancel] [Proceed with Downgrade]
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js bbd69fa 
>   ambari-web/app/messages.js 1fbaded 
>   ambari-web/app/templates/main/admin/stack_and_upgrade.hbs 674a58e 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs bca7dc8 
>   ambari-web/app/utils/ajax/ajax.js a7ee18d 
>   ambari-web/app/views/main/admin/stack_and_upgrade_view.js 0cb17ea 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js c4fc0ed 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js d4e819c 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 6388692 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js cba70bd 
> 
> Diff: https://reviews.apache.org/r/29805/diff/
> 
> 
> Testing
> -------
> 
> 5215 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>