You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/11 21:08:48 UTC
[GitHub] [incubator-yunikorn-k8shim] ronazhan opened a new pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
ronazhan opened a new pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191
Adding new podConfig and configMap structs to framework. Also updates the old tests to use these formats instead of previously hard-coded versions.
- Substitute pod config
- Substitute config map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-701103030
Thanks for the PR @ronazhan , and thanks for the review @ayubpathan .
+1, I will merge this shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ayubpathan commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
ayubpathan commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-701034788
LGTM. Thanks @ronazhan for working on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-692267661
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/d093b0d550e4aff685fdd42ed166db0ec77d27dd?el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 58.94% 58.61% -0.34%
==========================================
Files 33 33
Lines 3303 3303
==========================================
- Hits 1947 1936 -11
- Misses 1285 1295 +10
- Partials 71 72 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (-0.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=footer). Last update [d093b0d...260c1a7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ronazhan commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
ronazhan commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-691313249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-696455930
hi @ayubpathan could u pls help to review the PR? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-696455930
hi @ayubpathan could u pls help to review the PR? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ayubpathan commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
ayubpathan commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-701034872
@yangwwei Could you please help merge this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ronazhan commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
ronazhan commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-691313249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-692267661
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=h1) Report
> Merging [#191](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/d093b0d550e4aff685fdd42ed166db0ec77d27dd?el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 58.94% 58.61% -0.34%
==========================================
Files 33 33
Lines 3303 3303
==========================================
- Hits 1947 1936 -11
- Misses 1285 1295 +10
- Partials 71 72 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (-0.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=footer). Last update [d093b0d...260c1a7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/191?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ronazhan commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
ronazhan commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-691313249
@ayubpathan Can you review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #191: [YUNIKORN-411] Refactor podConfigs and configMap
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #191:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/191#issuecomment-696455930
hi @ayubpathan could u pls help to review the PR? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org