DO NOT REPLY [Bug 33104] New: - HttpServerletResponseWrapper deprecation errors with JDK 1.5

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33104>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33104

           Summary: HttpServerletResponseWrapper deprecation errors with JDK
                    1.5
           Product: Tomcat 5
           Version: 5.5.4
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Servlet & JSP API
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: tomcatlist@tkz.net


I get deprecation errors when trying a filter with Tomcat 5.5.4 and JDK 1.5 and
to minimize the variables, I've limited it down to the smallest possible
CLASSPATH and use case, using only the command line:

$ printenv CLASSPATH
.:/usr/java/jakarta-tomcat-5.5.4/common/lib/servlet-api.jar

$ java -version
java version "1.5.0_01"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_01-b08)
Java HotSpot(TM) Client VM (build 1.5.0_01-b08, mixed mode, sharing)

$ javac -Xlint:deprecation net/tkz/web/filter/TestWrapper.java
net/tkz/web/filter/TestWrapper.java:16: warning: [deprecation]
setStatus(int,java.lang.String) in javax.servlet.http.HttpServletResponse has
been deprecatedpublic class TestWrapper extends HttpServletResponseWrapper {
       ^
net/tkz/web/filter/TestWrapper.java:16: warning: [deprecation]
encodeRedirectUrl(java.lang.String) in javax.servlet.http.HttpServletResponse
has been deprecated
public class TestWrapper extends HttpServletResponseWrapper {
       ^
net/tkz/web/filter/TestWrapper.java:16: warning: [deprecation]
encodeUrl(java.lang.String) in javax.servlet.http.HttpServletResponse has been
deprecated
public class TestWrapper extends HttpServletResponseWrapper {
       ^
3 warnings

So after some detective work I did indeed come across the source code which
included the deprecated methods.  I downloaded source for both 5.5.4 and 5.5.6
and the latest version is unchanged.  The file in question is:
 
jakarta-tomcat-5.5.4-src/jakarta-servletapi-5/jsr154/src/share/javax/servlet/http/HttpServletResponseWrapper.java

I see from
http://cvs.apache.org/viewcvs.cgi/jakarta-servletapi-5/jsr154/src/share/javax/servlet/http/HttpServletResponseWrapper.java?rev=1.3&view=markup
that the deprecated code is still there.

It's my understanding that the tomcat 5.5 branch is a JDK 1.5 branch, so I
wanted to inquire about removing the deprecated methods from
HttpServletResponseWrapper and HttpServletResponse.  I'm willing to submit a
patch, if it would be useful.

My code used to work with tomcat4 and JDK 1.4.  I'll attach the simple test case
above that demonstrates the errors.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org