You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "gfakbar20 (via GitHub)" <gi...@apache.org> on 2025/04/27 08:35:42 UTC
[PR] Typo fix on access-control policy docs [polaris]
gfakbar20 opened a new pull request, #1472:
URL: https://github.com/apache/polaris/pull/1472
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
There are some typo left on my previous pr #1460 related to polaris policy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1472:
URL: https://github.com/apache/polaris/pull/1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "gfakbar20 (via GitHub)" <gi...@apache.org>.
gfakbar20 commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2062974516
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -159,7 +159,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| CATALOG_MANAGE_METADATA | Enables full management of the catalog, catalog roles, namespaces, and tables. |
| CATALOG_READ_PROPERTIES | Enables listing catalogs and reading properties of the catalog. |
| CATALOG_WRITE_PROPERTIES | Enables configuring catalog properties. |
-| NAMESPACE_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the namespace will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
+| CATALOG_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the catalog will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2064038553
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -159,7 +159,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| CATALOG_MANAGE_METADATA | Enables full management of the catalog, catalog roles, namespaces, and tables. |
| CATALOG_READ_PROPERTIES | Enables listing catalogs and reading properties of the catalog. |
| CATALOG_WRITE_PROPERTIES | Enables configuring catalog properties. |
-| NAMESPACE_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the namespace will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
+| CATALOG_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the catalog will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
Review Comment:
+1 for adding more documentation on the policy entity hierarchy and policy inheritance. We could include some diagrams on the Entities page to complement the API spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "gfakbar20 (via GitHub)" <gi...@apache.org>.
gfakbar20 commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2062979821
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -159,7 +159,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| CATALOG_MANAGE_METADATA | Enables full management of the catalog, catalog roles, namespaces, and tables. |
| CATALOG_READ_PROPERTIES | Enables listing catalogs and reading properties of the catalog. |
| CATALOG_WRITE_PROPERTIES | Enables configuring catalog properties. |
-| NAMESPACE_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the namespace will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
+| CATALOG_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the catalog will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
Review Comment:
but is there any plan to add a more elaborate explanation of each entities on the website? or the openapi-spec is intended to be a permanent/log-term solution in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2062890744
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -159,7 +159,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| CATALOG_MANAGE_METADATA | Enables full management of the catalog, catalog roles, namespaces, and tables. |
| CATALOG_READ_PROPERTIES | Enables listing catalogs and reading properties of the catalog. |
| CATALOG_WRITE_PROPERTIES | Enables configuring catalog properties. |
-| NAMESPACE_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the namespace will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
+| CATALOG_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the catalog will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
Review Comment:
Same here. I don't think it's necessary to explain how inheritance works in the privilege section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2063991050
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -159,7 +159,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| CATALOG_MANAGE_METADATA | Enables full management of the catalog, catalog roles, namespaces, and tables. |
| CATALOG_READ_PROPERTIES | Enables listing catalogs and reading properties of the catalog. |
| CATALOG_WRITE_PROPERTIES | Enables configuring catalog properties. |
-| NAMESPACE_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the namespace will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
+| CATALOG_ATTACH_POLICY | Enables attaching policy to a catalog. All entities registered under the catalog will inherit this policy unless they have a different policy of the same type. Only inheritable policy such as, table compaction and snapshot expiry policy are allowed in this level. |
Review Comment:
API spec should be the source of truth, but agreed we should add more doc for entity hierarchy and how policy inheritance works. We could add them in this page, https://polaris.apache.org/in-dev/unreleased/entities/. cc @HonahX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typo fix on access-control policy docs [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1472:
URL: https://github.com/apache/polaris/pull/1472#discussion_r2062886203
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -123,7 +123,7 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object
| TABLE_READ_DATA | Enables reading data from the table by receiving short-lived read-only storage credentials from the catalog. |
| TABLE_WRITE_DATA | Enables writing data to the table by receiving short-lived read+write storage credentials from the catalog. |
| TABLE_FULL_METADATA | Grants all table privileges, except TABLE_READ_DATA and TABLE_WRITE_DATA, which need to be granted individually. |
-| TABLE_ATTACH_POLICY | Enables attaching policy to a table. Applying policy at a table will override the same policy type defined at namespace and catalog |
+| TABLE_ATTACH_POLICY | Enables attaching policy to a table. Applying a policy at a table will override the same policy type defined at namespace and catalog |
Review Comment:
I don't think we need to mention the inheritance mechanism here, also it’s also not accurate, since a policy might not be inheritable.
```suggestion
| TABLE_ATTACH_POLICY | Enables attaching policy to a table. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org