You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/04/20 12:51:07 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #40878: [SPARK-42780][BUILD] Upgrade `Tink` to 1.9.0

LuciferYang commented on code in PR #40878:
URL: https://github.com/apache/spark/pull/40878#discussion_r1172542226


##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -59,9 +59,12 @@ datanucleus-core/4.1.17//datanucleus-core-4.1.17.jar
 datanucleus-rdbms/4.1.19//datanucleus-rdbms-4.1.19.jar
 derby/10.14.2.0//derby-10.14.2.0.jar
 dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar
+error_prone_annotations/2.18.0//error_prone_annotations-2.18.0.jar
 flatbuffers-java/1.12.0//flatbuffers-java-1.12.0.jar
 gcs-connector/hadoop3-2.2.11/shaded/gcs-connector-hadoop3-2.2.11-shaded.jar
 gmetric4j/1.0.10//gmetric4j-1.0.10.jar
+google-http-client/1.43.1//google-http-client-1.43.1.jar
+grpc-context/1.27.2//grpc-context-1.27.2.jar

Review Comment:
   Why does this version have GRPC related dependencies? Can we exclude them.
   
   CC @HyukjinKwon FYI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org