You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Li Zhiming (Code Review)" <ge...@cloudera.org> on 2020/10/14 07:53:38 UTC
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Li Zhiming has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16598
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/1
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 1
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16598 )
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
Patch Set 5:
Thanks for the patch! I know the change/functionality is trivial, but do you mind adding a test that deserializes into a scan token builder, adds a dynamic filter, and uses the token? That way we ensure we don't break the use case in the future.
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 5
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 14 Oct 2020 16:01:26 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16598
to look at the new patch set (#3).
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/3
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 3
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16598
to look at the new patch set (#6).
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
2 files changed, 48 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/6
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 6
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16598
to look at the new patch set (#5).
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/5
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 5
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16598
to look at the new patch set (#4).
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/4
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 4
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16598 )
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Reviewed-on: http://gerrit.cloudera.org:8080/16598
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
2 files changed, 48 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 7
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16598
to look at the new patch set (#2).
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
[java] add method to deserialize scanner token into scanner builder
To support build scanner with extra dynamic runtime filters.
Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/16598/2
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add method to deserialize scanner token into scanner builder
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16598 )
Change subject: [java] add method to deserialize scanner token into scanner builder
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17b24a8e9dec846583ad0940de19b96b672bd603
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 6
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 14:41:55 +0000
Gerrit-HasComments: No