You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jasvir Nagra (JIRA)" <ji...@apache.org> on 2009/01/08 04:02:44 UTC
[jira] Created: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Remove caja's dependence on opensocial feature
----------------------------------------------
Key: SHINDIG-822
URL: https://issues.apache.org/jira/browse/SHINDIG-822
Project: Shindig
Issue Type: Improvement
Components: Features (Javascript), Gadget Rendering Server (Java), OpenSocial feature (Javascript), Sample container & Examples
Reporter: Jasvir Nagra
Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by Louis Ryan <lr...@google.com>.
Chatted with Jasvir. He says it does not include a fix for that
issue. This patch should be fine however.
On Tue, Jun 23, 2009 at 12:57 PM, Paul Lindner <li...@inuus.com> wrote:
> I'm not sure if it does. Is there another issue open for that?
>
> On Mon, Jun 22, 2009 at 6:35 PM, Louis Ryan <lr...@google.com> wrote:
>
> > Does the updated Caja binary have a fix for the CSS DOM cloning issue?
> >
> > On Mon, Jun 22, 2009 at 5:42 PM, Paul Lindner (JIRA) <jira@apache.org
> > >wrote:
> >
> > >
> > > [
> > >
> >
> https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722916#action_12722916
> > ]
> > >
> > > Paul Lindner commented on SHINDIG-822:
> > > --------------------------------------
> > >
> > > Is there any reason that I shouldn't apply this patch?
> > >
> > > Been sitting around quite a while..
> > >
> > >
> > > > Remove caja's dependence on opensocial feature
> > > > ----------------------------------------------
> > > >
> > > > Key: SHINDIG-822
> > > > URL:
> https://issues.apache.org/jira/browse/SHINDIG-822
> > > > Project: Shindig
> > > > Issue Type: Improvement
> > > > Components: Java, Javascript
> > > > Reporter: Jasvir Nagra
> > > > Attachments: remove-caja-opensocial-dependence.patch
> > > >
> > > >
> > > > Moves caja container setup out of
> > > features/opensocial-reference/container.js to features/caja/caja.js.
> As
> > a
> > > result caja gadgets can run cajoled without requiring opensocial.
> > > > Feature libraries can use caja.tameModule___() to register a function
> > > which gets called to tame their api.
> > > > The pom changes updates the version of caja to one which supports
> > cajoled
> > > versions of prototype and jquery.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.
> > >
> > >
> >
>
Re: [jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by Paul Lindner <li...@inuus.com>.
I'm not sure if it does. Is there another issue open for that?
On Mon, Jun 22, 2009 at 6:35 PM, Louis Ryan <lr...@google.com> wrote:
> Does the updated Caja binary have a fix for the CSS DOM cloning issue?
>
> On Mon, Jun 22, 2009 at 5:42 PM, Paul Lindner (JIRA) <jira@apache.org
> >wrote:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722916#action_12722916
> ]
> >
> > Paul Lindner commented on SHINDIG-822:
> > --------------------------------------
> >
> > Is there any reason that I shouldn't apply this patch?
> >
> > Been sitting around quite a while..
> >
> >
> > > Remove caja's dependence on opensocial feature
> > > ----------------------------------------------
> > >
> > > Key: SHINDIG-822
> > > URL: https://issues.apache.org/jira/browse/SHINDIG-822
> > > Project: Shindig
> > > Issue Type: Improvement
> > > Components: Java, Javascript
> > > Reporter: Jasvir Nagra
> > > Attachments: remove-caja-opensocial-dependence.patch
> > >
> > >
> > > Moves caja container setup out of
> > features/opensocial-reference/container.js to features/caja/caja.js. As
> a
> > result caja gadgets can run cajoled without requiring opensocial.
> > > Feature libraries can use caja.tameModule___() to register a function
> > which gets called to tame their api.
> > > The pom changes updates the version of caja to one which supports
> cajoled
> > versions of prototype and jquery.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
Re: [jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by Louis Ryan <lr...@google.com>.
Does the updated Caja binary have a fix for the CSS DOM cloning issue?
On Mon, Jun 22, 2009 at 5:42 PM, Paul Lindner (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722916#action_12722916]
>
> Paul Lindner commented on SHINDIG-822:
> --------------------------------------
>
> Is there any reason that I shouldn't apply this patch?
>
> Been sitting around quite a while..
>
>
> > Remove caja's dependence on opensocial feature
> > ----------------------------------------------
> >
> > Key: SHINDIG-822
> > URL: https://issues.apache.org/jira/browse/SHINDIG-822
> > Project: Shindig
> > Issue Type: Improvement
> > Components: Java, Javascript
> > Reporter: Jasvir Nagra
> > Attachments: remove-caja-opensocial-dependence.patch
> >
> >
> > Moves caja container setup out of
> features/opensocial-reference/container.js to features/caja/caja.js. As a
> result caja gadgets can run cajoled without requiring opensocial.
> > Feature libraries can use caja.tameModule___() to register a function
> which gets called to tame their api.
> > The pom changes updates the version of caja to one which supports cajoled
> versions of prototype and jquery.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by Louis Ryan <lr...@google.com>.
Does the updated Caja binary have a fix for the CSS DOM cloning issue?
On Mon, Jun 22, 2009 at 5:42 PM, Paul Lindner (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722916#action_12722916]
>
> Paul Lindner commented on SHINDIG-822:
> --------------------------------------
>
> Is there any reason that I shouldn't apply this patch?
>
> Been sitting around quite a while..
>
>
> > Remove caja's dependence on opensocial feature
> > ----------------------------------------------
> >
> > Key: SHINDIG-822
> > URL: https://issues.apache.org/jira/browse/SHINDIG-822
> > Project: Shindig
> > Issue Type: Improvement
> > Components: Java, Javascript
> > Reporter: Jasvir Nagra
> > Attachments: remove-caja-opensocial-dependence.patch
> >
> >
> > Moves caja container setup out of
> features/opensocial-reference/container.js to features/caja/caja.js. As a
> result caja gadgets can run cajoled without requiring opensocial.
> > Feature libraries can use caja.tameModule___() to register a function
> which gets called to tame their api.
> > The pom changes updates the version of caja to one which supports cajoled
> versions of prototype and jquery.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661831#action_12661831 ]
Jasvir Nagra commented on SHINDIG-822:
--------------------------------------
To make it easier to code review, I've added this here http://codereview.appspot.com/11702
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), OpenSocial feature (Javascript), Sample container & Examples
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-822:
---------------------------------
Attachment: remove-caja-opensocial-dependence2.patch
I let the original patch go stale when I went on vacation.
Here's the updated one:
http://codereview.appspot.com/96186
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch, remove-caja-opensocial-dependence2.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723648#action_12723648 ]
Paul Lindner commented on SHINDIG-822:
--------------------------------------
there is some new caja code in container.js, Jasvir can you review those changes and submit a new patch?
Thanks!
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasvir Nagra updated SHINDIG-822:
---------------------------------
Attachment: remove-caja-opensocial-dependence.patch
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), OpenSocial feature (Javascript), Sample container & Examples
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722916#action_12722916 ]
Paul Lindner commented on SHINDIG-822:
--------------------------------------
Is there any reason that I shouldn't apply this patch?
Been sitting around quite a while..
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666820#action_12666820 ]
Jasvir Nagra commented on SHINDIG-822:
--------------------------------------
Thank you Paul. I'll address your comments and update the patch.
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), OpenSocial feature (Javascript), Sample container & Examples
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666807#action_12666807 ]
Paul Lindner commented on SHINDIG-822:
--------------------------------------
reviewed...
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), OpenSocial feature (Javascript), Sample container & Examples
> Reporter: Jasvir Nagra
> Attachments: remove-caja-opensocial-dependence.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-822) Remove caja's dependence on
opensocial feature
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-822.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA2
applied. Thanks!
> Remove caja's dependence on opensocial feature
> ----------------------------------------------
>
> Key: SHINDIG-822
> URL: https://issues.apache.org/jira/browse/SHINDIG-822
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Jasvir Nagra
> Fix For: 1.1-BETA2
>
> Attachments: remove-caja-opensocial-dependence.patch, remove-caja-opensocial-dependence2.patch
>
>
> Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial.
> Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api.
> The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.