You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2012/12/29 04:48:21 UTC

[jira] [Commented] (SOLR-4232) Make request handler metrics optional

    [ https://issues.apache.org/jira/browse/SOLR-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540747#comment-13540747 ] 

Shawn Heisey commented on SOLR-4232:
------------------------------------

I believe I finally grokked the leak in SOLR-1972.  I have a new idea -- make RequestHandlerBase implement Closeable and add a call to close() everywhere that a handler should be destroyed.  If this issue is considered a good idea, I will do so as part of the new approach in SOLR-1972.
                
> Make request handler metrics optional
> -------------------------------------
>
>                 Key: SOLR-4232
>                 URL: https://issues.apache.org/jira/browse/SOLR-4232
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 4.1, 5.0
>            Reporter: Shawn Heisey
>            Priority: Blocker
>             Fix For: 4.2, 5.0
>
>
> Uwe Schindler noticed what looked like a memory leak caused by the addition of SOLR-1972.  I don't believe it's actually a leak, but the additional memory required does appear to be causing problems for Solr test JVMs.  I think this is likely because there are a LOT of request handlers defined for even a very minimal test config, each of which ends up with the new objects.
> This is an attempt to provide an option for turning on the new statistics only when required.  For most people, this will only be required for search handlers.
> If this is not successful at fixing the test problems, we can remove metrics with this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org