You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2023/04/18 05:42:32 UTC

[GitHub] [phoenix-connectors] stoty opened a new pull request, #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

stoty opened a new pull request, #97:
URL: https://github.com/apache/phoenix-connectors/pull/97

   skip Javadoc generation for Spark connector on JDK 9+


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-connectors] stoty commented on pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #97:
URL: https://github.com/apache/phoenix-connectors/pull/97#issuecomment-1512471176

   Note that the tests still fail with Java 11, but that's a different issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-connectors] richardantal commented on a diff in pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

Posted by "richardantal (via GitHub)" <gi...@apache.org>.
richardantal commented on code in PR #97:
URL: https://github.com/apache/phoenix-connectors/pull/97#discussion_r1176464774


##########
phoenix5-spark3/pom.xml:
##########
@@ -183,6 +183,15 @@
             </ignoredDependencies>
           </configuration>
         </plugin>
+        <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-javadoc-plugin</artifactId>
+            <configuration>
+                <skip>${skip.spark.javadoc}</skip>
+            </configuration>
+        </plugin>
     </plugins>
   </build>
+    <profiles>
+    </profiles>

Review Comment:
   Can you remove this empty profiles block?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-connectors] stoty closed pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty closed pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11
URL: https://github.com/apache/phoenix-connectors/pull/97


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-connectors] stoty commented on pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #97:
URL: https://github.com/apache/phoenix-connectors/pull/97#issuecomment-1522100234

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 17s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m  8s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  17m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 59s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  16m  3s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 59s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 59s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  4s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 115m 46s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   0m 29s |  The patch generated 5 ASF License warnings.  |
   |  |   | 175m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-97/4/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/97 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux 8a47b02184ff 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 229c155 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-97/4/artifact/yetus-general-check/output/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-97/4/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-97/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
   | Max. process+thread count | 1926 (vs. ulimit of 30000) |
   | modules | C: phoenix-spark-base phoenix5-spark3 . U: . |
   | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-97/4/console |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-connectors] stoty commented on a diff in pull request #97: PHOENIX-6922 Javadoc failure while building connectors with Java 11

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #97:
URL: https://github.com/apache/phoenix-connectors/pull/97#discussion_r1176541474


##########
phoenix5-spark3/pom.xml:
##########
@@ -183,6 +183,15 @@
             </ignoredDependencies>
           </configuration>
         </plugin>
+        <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-javadoc-plugin</artifactId>
+            <configuration>
+                <skip>${skip.spark.javadoc}</skip>
+            </configuration>
+        </plugin>
     </plugins>
   </build>
+    <profiles>
+    </profiles>

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org