You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/23 13:40:35 UTC

[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2942: [Camel 3.11] Solr cloud integration tests are failing #2814

JiriOndrusek opened a new pull request #2942:
URL: https://github.com/apache/camel-quarkus/pull/2942


   fixes https://github.com/apache/camel-quarkus/issues/2814
   
   I used docker-compose approach for the cloud test resource. Previously used solr container (in case of cloud configuration), even when started with zookeeper, has a problem with accessing Zookeeper - problem mentioned [here](https://stackoverflow.com/questions/58001396/zookeeper-solr-in-testcontainers). Usage of docker compose allows defining Solr's and Zookeeper's cloud in a way, that everything works. Moreover testcontaioner's implementation of docker-compose creates automaically a simple container (`ambassador` - https://www.testcontainers.org/modules/docker_compose/), which works as a proxy to internal docker's network and exposes required ports to outside. It is possible to use random ports and (from my perspective) having cluster configuration in a yaml file makes it easily understandable.
   
   Another issue reported as https://github.com/apache/camel-quarkus/issues/2941
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2942: [Camel 3.11] Solr cloud integration tests are failing #2814

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2942:
URL: https://github.com/apache/camel-quarkus/pull/2942#discussion_r676501487



##########
File path: extensions/solr/deployment/src/main/java/org/apache/camel/quarkus/component/solr/deployment/SolrProcessor.java
##########
@@ -65,6 +66,8 @@ void registerForReflection(BuildProducer<ReflectiveClassBuildItem> reflectiveCla
                     }
                 })
                 .forEach(reflectiveClass::produce);
+
+        reflectiveClass.produce(new ReflectiveClassBuildItem(false, false, ClientCnxnSocketNIO.class.getName()));

Review comment:
       We are registering the same class in HBaseProcessor. This is perhaps not enough for a separate support extension yet. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga merged pull request #2942: [Camel 3.11] Solr cloud integration tests are failing #2814

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2942:
URL: https://github.com/apache/camel-quarkus/pull/2942


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org