You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by panarasi <gi...@git.apache.org> on 2015/04/28 05:13:20 UTC
[GitHub] cordova-windows pull request: Added support for Windows 10
GitHub user panarasi opened a pull request:
https://github.com/apache/cordova-windows/pull/70
Added support for Windows 10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows win10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/70.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #70
----
commit 291780575c7884d7fd123348faeb46ebc6075b54
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-04-23T23:26:40Z
Added support for Windows 10.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/70#discussion_r29215398
--- Diff: template/cordova/lib/run.js ---
@@ -92,21 +152,26 @@ module.exports.help = function () {
console.log(' run --target=7988B8C3-3ADE-488d-BA3E-D052AC9DC710');
console.log(' run --device --release');
console.log(' run --emulator --debug');
+ console.log(' run --device --appx=phone-8.1');
console.log('');
+
process.exit(0);
};
function getWindowsTargetVersion() {
var config = new ConfigParser(path.join(ROOT, 'config.xml'));
- var windowsTargetVersion = config.getPreference('windows-target-version');
+ var windowsTargetVersion = config.getWindowsTargetVersion();
switch(windowsTargetVersion) {
- case '8':
- case '8.0':
- return '8.0';
- case '8.1':
- return '8.1';
- default:
- throw new Error('Unsupported windows-target-version value: ' + windowsTargetVersion);
+ case '8':
+ case '8.0':
+ return '8.0';
+ case '8.1':
+ return '8.1';
+ case '10.0':
--- End diff --
We might want to support just plain old '10' here as well, I had to dig for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-96907329
please rebase, there are merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by dukex <gi...@git.apache.org>.
Github user dukex commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/70#discussion_r29250001
--- Diff: spec/unit/build.spec.js ---
@@ -44,11 +44,17 @@ function createConfigParserMock(winVersion, phoneVersion) {
return {
getPreference: function(prefName) {
switch (prefName) {
- case 'windows-target-version':
+ case 'WindowsTargetVersion':
return winVersion;
- case 'windows-phone-target-version':
--- End diff --
Sorry, my bad!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by axemclion <gi...@git.apache.org>.
Github user axemclion commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-96912928
@purplecabbage I actually accepted this pull requests - thought it was easier to test in the feature branch. Is that ok ? If not, I can delete the windows10 branch and create a new one again.
Note that we should not merge this into master yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-96913394
That is fine. Yeah, I was just looking at doing the same thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/70#discussion_r29265000
--- Diff: template/cordova/lib/run.js ---
@@ -92,21 +152,26 @@ module.exports.help = function () {
console.log(' run --target=7988B8C3-3ADE-488d-BA3E-D052AC9DC710');
console.log(' run --device --release');
console.log(' run --emulator --debug');
+ console.log(' run --device --appx=phone-8.1');
console.log('');
+
process.exit(0);
};
function getWindowsTargetVersion() {
var config = new ConfigParser(path.join(ROOT, 'config.xml'));
- var windowsTargetVersion = config.getPreference('windows-target-version');
+ var windowsTargetVersion = config.getWindowsTargetVersion();
switch(windowsTargetVersion) {
- case '8':
- case '8.0':
- return '8.0';
- case '8.1':
- return '8.1';
- default:
- throw new Error('Unsupported windows-target-version value: ' + windowsTargetVersion);
+ case '8':
+ case '8.0':
+ return '8.0';
+ case '8.1':
+ return '8.1';
+ case '10.0':
--- End diff --
Probably a fair comment. I expect us to see more minor revisions over time (similar to how 8 and 8.1 were, although with the same project instead of different ones) and we designed it with that in mind. If you want to target 10 base, you can use "UAP" here instead (aligned with the --appx=uap CLI option).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-96920653
Run the 10.0 target with:
`cordova run windows --target=10.0`
or
`cordova run windows --target=uap`
or add the following to your config.xml:
`<preference name="WindowsTargetVersion" value="10.0"></preference>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/70#discussion_r29249044
--- Diff: spec/unit/build.spec.js ---
@@ -44,11 +44,17 @@ function createConfigParserMock(winVersion, phoneVersion) {
return {
getPreference: function(prefName) {
switch (prefName) {
- case 'windows-target-version':
+ case 'WindowsTargetVersion':
return winVersion;
- case 'windows-phone-target-version':
--- End diff --
`windows-phone-target-version` should continue to work. See `config.getWindowsPhoneTargetVersion` implementation
```
getWindowsPhoneTargetVersion: function() {
...
+ var explicitPreference = this.getPreference('WindowsPhoneTargetVersion') || this.getPreference('windows-phone-target-version');
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by panarasi <gi...@git.apache.org>.
Github user panarasi closed the pull request at:
https://github.com/apache/cordova-windows/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by axemclion <gi...@git.apache.org>.
Github user axemclion commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-97248017
Closing this PR, commit was merged into the Apache/windows10 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by axemclion <gi...@git.apache.org>.
Github user axemclion commented on the pull request:
https://github.com/apache/cordova-windows/pull/70#issuecomment-96914584
Leaving a comment for reference.
To try this platform, use
`cordova platform add windows@https://github.com/apache/cordova-windows/archive/win10.v1.tar.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Added support for Windows 10
Posted by dukex <gi...@git.apache.org>.
Github user dukex commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/70#discussion_r29226500
--- Diff: spec/unit/build.spec.js ---
@@ -44,11 +44,17 @@ function createConfigParserMock(winVersion, phoneVersion) {
return {
getPreference: function(prefName) {
switch (prefName) {
- case 'windows-target-version':
+ case 'WindowsTargetVersion':
return winVersion;
- case 'windows-phone-target-version':
--- End diff --
There is a good reason for break the compatibility of config?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org