[GitHub] [hudi] codope commented on a change in pull request #3184: [HUDI-1860] Add INSERT_OVERWRITE and INSERT_OVERWRITE_TABLE support to DeltaStreamer

[GitBox <gi...@apache.org>]

codope commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r666687005



##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java
##########
@@ -53,14 +54,37 @@ public HoodieDeltaStreamerWrapper(Config cfg, JavaSparkContext jssc) throws Exce
     return upsert(WriteOperationType.BULK_INSERT);
   }
 
+  public JavaRDD<WriteStatus> insertOverwrite() throws
+          Exception {
+    return insertOverwrite(WriteOperationType.INSERT_OVERWRITE);
+  }
+
+  public JavaRDD<WriteStatus> insertOverwrite(WriteOperationType operation) throws Exception {
+    cfg.operation = operation;
+    return deltaSyncService.get().getDeltaSync().syncOnce().getRight();
+  }
+
+  public JavaRDD<WriteStatus> insertOverwriteTable() throws
+          Exception {
+    return insertOverwriteTable(WriteOperationType.INSERT_OVERWRITE_TABLE);
+  }
+
+  public JavaRDD<WriteStatus> insertOverwriteTable(WriteOperationType operation) throws

Review comment:
       Instead of new method, can we not reuse `insertOverwrite()` method in line 62? Note that these wrapper methods are only used for integration test suite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org