You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2023/05/22 04:31:52 UTC

[GitHub] [seatunnel] liugddx commented on a diff in pull request #4764: [hotfix][kafka] Fix the problem that the partition information cannot be obtained when kafka is restored

liugddx commented on code in PR #4764:
URL: https://github.com/apache/seatunnel/pull/4764#discussion_r1199943681


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/SourceSplitEnumeratorTask.java:
##########
@@ -141,7 +141,7 @@ public void triggerBarrier(Barrier barrier) throws Exception {
         final long barrierId = barrier.getId();
         Serializable snapshotState = null;
         byte[] serialize = null;
-        synchronized (enumeratorContext) {
+        synchronized (source) {

Review Comment:
   This is a warning, because the lock object is not final. So I chose a final modified lock.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org