You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "platinumhamburg (via GitHub)" <gi...@apache.org> on 2026/10/23 14:32:09 UTC
[PR] [metrics] Expire idle histogram samples across reporters [fluss]
platinumhamburg opened a new pull request, #4829:
URL: https://github.com/apache/fluss/pull/4829
### Purpose
Linked issue: closes #4828. Related to #4139.
Built-in histograms currently retain their last observations indefinitely when traffic stops. This change bounds samples by both count and a five-minute age, and defines what each reporter exposes when the current window is empty. PR #4167 overlaps the sample-expiration portion; this PR also covers the reporter contract.
### Brief change log
- Apply the five-minute age to all built-in `DescriptiveStatisticsHistogram` instances while retaining each existing sample cap and cumulative lifetime count. The existing one-argument constructor remains unbounded for external callers.
- Omit Prometheus quantiles for an empty window while retaining `_count`.
- Emit `windowCount` and omit empty distribution fields in InfluxDB; expose `WindowCount` in JMX for interpreting its existing numeric attributes.
### Tests
- Java 11: 31 focused tests across `DescriptiveStatisticsHistogramTest`, `PrometheusReporterTest`, `InfluxdbPointProducerTest`, and `JMXReporterTest` passed.
- Java 11: affected RPC, Server, and Client modules compiled with `-DskipTests`.
- Spotless, Checkstyle, RAT, and `git diff --check` passed for the affected build.
### API and Format
The histogram constructor gains an optional maximum age. JMX gains `WindowCount`; InfluxDB histogram points gain `windowCount`. Prometheus summary quantiles disappear during an empty window and return after a new observation. Metric names and storage formats remain unchanged.
### Documentation
Updated the metric reporter documentation with window and empty-window semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [metrics] Expire idle histogram samples across reporters [fluss]
Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos merged PR #4829:
URL: https://github.com/apache/fluss/pull/4829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [metrics] Expire idle histogram samples across reporters [fluss]
Posted by "platinumhamburg (via GitHub)" <gi...@apache.org>.
platinumhamburg commented on PR #4829:
URL: https://github.com/apache/fluss/pull/4829#issuecomment-6487785490
Hi @polyzos , could you take a look at this PR when you have time? It expires idle histogram samples so request latency metrics stop reporting stale values after traffic subsides. This should also help make the queueing observations in #4926 easier to interpret. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [metrics] Expire idle histogram samples across reporters [fluss]
Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos commented on PR #4829:
URL: https://github.com/apache/fluss/pull/4829#issuecomment-6493271494
Thanks @platinumhamburg! I rebased onto main and pushed one small commit two changes:
- Prometheus now reports NaN quantiles for an empty window instead of omitting them. This matches client_java Summary and keeps the series continuous.
- Docs: the empty-window rules are now in their own Histograms section, with a note on Flink reporters.
Please let me know your thoughts and i can merge once the CI passes 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [metrics] Expire idle histogram samples across reporters [fluss]
Posted by "platinumhamburg (via GitHub)" <gi...@apache.org>.
platinumhamburg commented on PR #4829:
URL: https://github.com/apache/fluss/pull/4829#issuecomment-6496051576
Thanks @polyzos for the review and for helping improve this PR! Both changes look good to me. CI is green, happy to merge 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org