You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/23 12:57:47 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
HyukjinKwon opened a new pull request #28908:
URL: https://github.com/apache/spark/pull/28908
### What changes were proposed in this pull request?
Spark 3.0 accidentally dropped R < 3.5. It is built by R 3.6.3 which not support R < 3.5:
{code}
Error in readRDS(pfile) : cannot read workspace version 3 written by R 3.6.3; need R 3.5.0 or newer version.
{code}
In fact, with SPARK-31918, we will have to drop R < 3.5 entirely to support R 4.0.0. This is inevitable to release on CRAN because they require to make the tests pass with the latest R.
### Why are the changes needed?
To show the supported versions correctly, and support R 4.0.0 to unblock the releases.
### Does this PR introduce _any_ user-facing change?
In fact, no because Spark 3.0.0 already does not work with R < 3.5.
Compared to Spark 2.4, yes. R < 3.5 would not work.
### How was this patch tested?
Jenkins should test it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648539134
Merged to master, branch-3.0 and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648129845
**[Test build #124421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124421/testReport)** for PR 28908 at commit [`d48ecf9`](https://github.com/apache/spark/commit/d48ecf971bff093406cfed20ff7d42682cb8e295).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648128483
Jenkins R's 3.4 IIRC. I will see the test results first, and let the appropriate person know and update the env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28908:
URL: https://github.com/apache/spark/pull/28908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648536691
Oh, just as a note to my self, Jenkins R version seems to be 3.5.2:
```
using R version 3.5.2 (2018-12-20)
```
Nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648130499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648154467
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648368937
As we accidentally dropped R < 3.5 in Spark 3.0.0, can we update the doc like https://spark.apache.org/docs/latest/index.html to make it less confusing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shivaram commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
shivaram commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648204845
LGTM. Thanks @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648548000
I think so .. I will at least target to test 4.0 in AppVeyor at https://github.com/apache/spark/pull/28909 for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648129845
**[Test build #124421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124421/testReport)** for PR 28908 at commit [`d48ecf9`](https://github.com/apache/spark/commit/d48ecf971bff093406cfed20ff7d42682cb8e295).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shivaram commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
shivaram commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648540356
> Oh, just as a note to my self, Jenkins R version seems to be 3.5.2:
>
> ```
> using R version 3.5.2 (2018-12-20)
> ```
>
> Nice.
Hah - we should file a JIRA to upgrade it to 4.0 or at least 3.6.3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648322331
Thanks, @HyukjinKwon . BTW, if we accidentally dropped it, how can we mention it in this case? This PR should target `Apache Spark 3.0.1` with `releasenotes` label? (For now, it's just a normal JIRA issue.)
cc @gatorsmile and @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648533430
@viirya, it will be ported back to branch-3.0 and 3.0.1 will contains the doc fixes there. It should be fine with 3.0.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648154467
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648154238
**[Test build #124421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124421/testReport)** for PR 28908 at commit [`d48ecf9`](https://github.com/apache/spark/commit/d48ecf971bff093406cfed20ff7d42682cb8e295).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648533571
Sure, I added `releasenotes` label in the JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28908: [SPARK-32073][R] Drop R < 3.5 support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28908:
URL: https://github.com/apache/spark/pull/28908#issuecomment-648130499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org