[jira] [Commented] (CB-10047) [StatusBar] Fix iOS8 Deprecation Warnings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157456#comment-15157456 ] 

ASF GitHub Bot commented on CB-10047:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/48

    CB-10047 fix iOS 8 deprecated warnings

    Removed all references to self.viewController.interfaceOrientation,
    they weren’t really used on invertFrameIfNeeded and are deprecated on
    iOS 8
    Removed orientation param on invertFrameIfNeeded as it wasn’t being
    used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-10047-ios-statusbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit 5beb8a2a6eb9a2e87b171e1cf0112e11879cd2f4
Author: Julio César <jc...@gmail.com>
Date:   2016-02-22T18:41:22Z

    CB-10047 fix iOS 8 deprecated warnings
    
    Removed all references to self.viewController.interfaceOrientation,
    they weren’t really used on invertFrameIfNeeded and are deprecated on
    iOS 8
    Removed orientation param on invertFrameIfNeeded as it wasn’t being
    used.

----


> [StatusBar] Fix iOS8 Deprecation Warnings
> -----------------------------------------
>
>                 Key: CB-10047
>                 URL: https://issues.apache.org/jira/browse/CB-10047
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>            Reporter: jordan cardwell
>            Assignee: jcesarmobile
>            Priority: Minor
>              Labels: deprecated, deprecation
>
> Issue has been around for a while
> [https://github.com/apache/cordova-plugin-statusbar/pull/26]
> After use Cordova build ios
> there are some warning about UIDeviceOrientation and UIInterfaceOrientation:
> Implicit conversion from enumeration type "UIDeviceOrientation"(aka "enum UIDeviceOrientation") to different enumeration type "UIInterfaceOrientation" (aka "enum UIInterfaceOrientation")
> Based on current ios api, UIViewControl.interfaceOrientation has been deprecated.
> Fixed those warning using function: [[UIDevice currentDevice] orientation] instead of self.viewController.interfaceOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org