You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/23 07:52:45 UTC

[GitHub] [cordova-ios] erisu opened a new pull request #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging

erisu opened a new pull request #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging
URL: https://github.com/apache/cordova-ios/pull/798
 
 
   ### Motivation and Context
   
   Improve the boolean checks for preference settings and logging.
   
   ### Description
   
   Updated the `cordovaBoolSettingForKey` method.
   
   ### Testing
   
   - `npm t`
   - `cordova platform add`
   - `cordova build`
   - Run in simulator and test with different values
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] erisu merged pull request #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging
URL: https://github.com/apache/cordova-ios/pull/798
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io commented on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging
URL: https://github.com/apache/cordova-ios/pull/798#issuecomment-590683226
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=h1) Report
   > Merging [#798](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/798/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #798   +/-   ##
   =======================================
     Coverage   74.36%   74.36%           
   =======================================
     Files          13       13           
     Lines        1845     1845           
   =======================================
     Hits         1372     1372           
     Misses        473      473
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=footer). Last update [4ac1552...6ad57c5](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging
URL: https://github.com/apache/cordova-ios/pull/798#issuecomment-590683226
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=h1) Report
   > Merging [#798](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/798/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #798   +/-   ##
   =======================================
     Coverage   74.36%   74.36%           
   =======================================
     Files          13       13           
     Lines        1845     1845           
   =======================================
     Hits         1372     1372           
     Misses        473      473
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=footer). Last update [4ac1552...6ad57c5](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #798: refactor (cordovaBoolSettingForKey): improve boolean checks and native logging
URL: https://github.com/apache/cordova-ios/pull/798#issuecomment-590683226
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=h1) Report
   > Merging [#798](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/798/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #798   +/-   ##
   =======================================
     Coverage   74.36%   74.36%           
   =======================================
     Files          13       13           
     Lines        1845     1845           
   =======================================
     Hits         1372     1372           
     Misses        473      473
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=footer). Last update [4ac1552...6ad57c5](https://codecov.io/gh/apache/cordova-ios/pull/798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org