You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/29 02:37:45 UTC

[GitHub] [dolphinscheduler] HeZean commented on a diff in pull request #11642: [Fix-11583][UI] Fix the API usage of gantt graph

HeZean commented on code in PR #11642:
URL: https://github.com/apache/dolphinscheduler/pull/11642#discussion_r956848295


##########
dolphinscheduler-ui/src/views/projects/workflow/instance/gantt/components/gantt-chart.tsx:
##########
@@ -80,7 +80,7 @@ const GanttChart = defineComponent({
       minTime = minTime < start ? minTime : start
       maxTime = maxTime > end ? maxTime : end
       data[task.status].push({
-        name: task.name,
+        name: task.taskName,

Review Comment:
   Thanks for reminding. IMHO we can remove `name` here since it's just a dup of taskName?
   <img width="438" alt="Screen Shot 2022-08-29 at 10 35 47" src="https://user-images.githubusercontent.com/49837965/187111825-7d35f09e-f6c3-4da2-b2fd-61cfb4c741a6.png">
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org