[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r893928279


##########
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java:
##########
@@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out) throws IOException {
       InternalDataSerializer.writeArrayLength(size, out);
       if (size > 0) {
         DataSerializer.writeObject(name[0], out);
-        DataSerializer.writeObject(op, out);
+        DataSerializer.writeObject(op.id, out);

Review Comment:
   It looks like no, because when constructed with `null` the `name` will also be `null`. This means that if a message is added then the op is taking from the first message added, otherwise if it remains empty when serialized the `op.id` is never referenced. To be absolutely clear though I am going to `@NotNull` in that constructor, add a new default constructor for the empty case so it isn't called with `null`, guaranteeing that both `name` and `op` will be `null` together. Good find!!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org