[jira] [Comment Edited] (FLINK-20297) Make `SerializerTestBase::getTestData` return List

["Dawid Wysakowicz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-20297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242203#comment-17242203 ] 

Dawid Wysakowicz edited comment on FLINK-20297 at 12/2/20, 9:36 AM:
--------------------------------------------------------------------

Can you elaborate why it is not possible to override said method? As far as I know it should be possible. We even do that already e.g. in {{ScalaCaseClassSerializerTest}} or {{EitherSerializerTest}}.


was (Author: dawidwys):
Can you elaborate why it is not possible to override said method? As far as I know it should be possible. We even do that already e.g. in {{ScalaCaseClassSerializerTest}}.

> Make `SerializerTestBase::getTestData` return List<T>
> -----------------------------------------------------
>
>                 Key: FLINK-20297
>                 URL: https://issues.apache.org/jira/browse/FLINK-20297
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Type Serialization System
>            Reporter: Guowei Ma
>            Assignee: Guowei Ma
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently `SerializerTestBase::getTestData` return T[], which can not be override by the Scala. It means that developer could not add scala serializer test based on `SerializerTestBase`
> So I would propose to change the `SerializerTestBase::getTestData` to return List<T>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)