You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/10/13 09:27:39 UTC

[GitHub] [dolphinscheduler] lenboo commented on a change in pull request #6521: [1.3.9-prepare#6387][Task] sql limit param no default value

lenboo commented on a change in pull request #6521:
URL: https://github.com/apache/dolphinscheduler/pull/6521#discussion_r727873604



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##########
@@ -280,7 +285,9 @@ private void resultProcess(ResultSet resultSet) throws Exception{
 
         int rowCount = 0;
 
-        while (rowCount < sqlParameters.getLimit() && resultSet.next()) {
+        int limit = sqlParameters.getLimit() == 0 ? QUERY_LIMIT : sqlParameters.getLimit();

Review comment:
       We need to be reminded that the maximum is limit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org