You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 12:56:28 UTC
[GitHub] [superset] codecov-io commented on pull request #13210: feat(explore): ColumnSelectControl with drag-and-drop
codecov-io commented on pull request #13210:
URL: https://github.com/apache/superset/pull/13210#issuecomment-783353940
# [Codecov](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=h1) Report
> Merging [#13210](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=desc) (58beef1) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **decrease** coverage by `13.72%`.
> The diff coverage is `16.19%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13210/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13210 +/- ##
===========================================
- Coverage 72.29% 58.57% -13.73%
===========================================
Files 864 442 -422
Lines 44883 13394 -31489
Branches 5403 3548 -1855
===========================================
- Hits 32450 7845 -24605
+ Misses 12224 5549 -6675
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.57% <16.19%> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-10.88%)` | :arrow_down: |
| [...ls/DndColumnSelectControl/DndColumnSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ndColumnSelectControl/components/OptionWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uV3JhcHBlci50c3g=) | `0.00% <0.00%> (ø)` | |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...nts/DatasourcePanel/DatasourcePanelDragWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIudHN4) | `100.00% <100.00%> (ø)` | |
| [...nd/src/explore/components/DatasourcePanel/types.ts](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `70.51% <100.00%> (+0.63%)` | :arrow_up: |
| [...omponents/controls/DndColumnSelectControl/types.ts](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3R5cGVzLnRz) | `100.00% <100.00%> (ø)` | |
| ... and [812 more](https://codecov.io/gh/apache/superset/pull/13210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=footer). Last update [9b5e66b...58beef1](https://codecov.io/gh/apache/superset/pull/13210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org