[jira] [Commented] (HADOOP-10428) JavaKeyStoreProvider should accept keystore password via configuration falling back to ENV VAR

["Aaron T. Myers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958274#comment-13958274 ] 

Aaron T. Myers commented on HADOOP-10428:
-----------------------------------------

Patch looks good to me. One small comment:

{code}
hadoop.security.keystore.JavaKeyStoreProvider.password
{code}

I think in general we tend to avoid camel-casing property names, so maybe could pick a better one here? Is there some reason we _have_ to include the class name in this property name? I don't feel super strongly about it. Feel free to ignore this comment if you'd like.

+1 once the above is addressed, either by saying you don't think it should be changed, or by changing it.

> 	JavaKeyStoreProvider should accept keystore password via configuration falling back to ENV VAR
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10428
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-10428.patch
>
>
> Currently the password for the {{JavaKeyStoreProvider}} must be set in an ENV VAR.
> Allowing the password to be set via configuration enables applications to interactively ask for the password before initializing the {{JavaKeyStoreProvider}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)