You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2011/08/25 13:51:29 UTC
[jira] [Created] (QPID-3454) System test StreamMessageTest would
not detect regression in StreamMessage buffer expansion.
System test StreamMessageTest would not detect regression in StreamMessage buffer expansion.
--------------------------------------------------------------------------------------------
Key: QPID-3454
URL: https://issues.apache.org/jira/browse/QPID-3454
Project: Qpid
Issue Type: Bug
Components: Java Tests
Affects Versions: 0.10, 0.11, 0.12
Reporter: Keith Wall
Assignee: Keith Wall
Fix For: 0.13
A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
The test incorrectly uses a Junit assertion _within_ a onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3454) System test StreamMessageTest would
not detect regression in StreamMessage buffer expansion.
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3454:
-----------------------------
Status: Ready To Review (was: In Progress)
> System test StreamMessageTest would not detect regression in StreamMessage buffer expansion.
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3454
> URL: https://issues.apache.org/jira/browse/QPID-3454
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.10, 0.11, 0.12
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
> The test incorrectly uses a Junit assertion _within_ an onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3454) System test StreamMessageTest would
not detect regression in StreamMessage buffer expansion.
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3454:
-----------------------------
Description:
A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
The test incorrectly uses a Junit assertion _within_ an onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
was:
A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
The test incorrectly uses a Junit assertion _within_ a onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
> System test StreamMessageTest would not detect regression in StreamMessage buffer expansion.
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3454
> URL: https://issues.apache.org/jira/browse/QPID-3454
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.10, 0.11, 0.12
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
> The test incorrectly uses a Junit assertion _within_ an onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3454) System test StreamMessageTest would
not detect regression in StreamMessage buffer expansion.
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3454:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
Hi Robbie, can you review this change please?
> System test StreamMessageTest would not detect regression in StreamMessage buffer expansion.
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3454
> URL: https://issues.apache.org/jira/browse/QPID-3454
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.10, 0.11, 0.12
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
> The test incorrectly uses a Junit assertion _within_ an onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3454) System test StreamMessageTest would
not detect regression in StreamMessage buffer expansion.
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3454.
----------------------------------
Resolution: Fixed
Changes seem good to me.
> System test StreamMessageTest would not detect regression in StreamMessage buffer expansion.
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3454
> URL: https://issues.apache.org/jira/browse/QPID-3454
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.10, 0.11, 0.12
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> A defect in the logic of StreamMessageTest#testModifyReceivedMessageExpandsBuffer would mean that a regression could go unnoticed.
> The test incorrectly uses a Junit assertion _within_ an onMessage. Unfortunately if this assertion were to ever fail, the Junit test harness would not hear the assertion fail as onMessage is executed by a separate thread.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org